Remove dependency on Half only where obsolete#27
Open
dabrahams wants to merge 10 commits intoSomeRandomiOSDev:mainfrom
Open
Remove dependency on Half only where obsolete#27dabrahams wants to merge 10 commits intoSomeRandomiOSDev:mainfrom
dabrahams wants to merge 10 commits intoSomeRandomiOSDev:mainfrom
Conversation
These changes will break anyone depending on (de)coding Half on ARM architectures.
Owner
|
@dabrahams I created a release to address a lot of the issues that came up due to this repo being so out of date. Please rebase on this release and update this PR accordingly |
Otherwise it gets deleted from Package.resolved
8 tasks
Contributor
Author
|
@SomeRandomiOSDev Rebasing is going to be tough. I'm just trying to get as far as making a merge work; I'm not an Xcode/carthage/cocoapods/whatever jock, so making all those parts work is a challenge for me. It's not clear whether you're willing to accept the minimum deployment targets advancing considerably in order to get |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is just #21 but with
Halfstill in use on x64 Macs. I need to remove theHalfdependency in order to run on Windows but unfortunately x64 Macs (only!) don't supportFloat16.Fixes #29 by avoiding SomeRandomiOSDev/Half#16
Checklist
Ensure that your
pull requesthas followed all the steps below:workflowtests.sh fails, but it already fails for me on your
mainbranch. I'll report a separate issue.I'm already in CONTRIBUTORS.md
Proposed changes
In addition to the motivation above, see #21.